Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix javadocs for telemetry core #241

Conversation

uaihebert
Copy link
Contributor

@uaihebert uaihebert commented Oct 1, 2020

fix #236

@uaihebert
Copy link
Contributor Author

After this PR gets merged, I will work on the last one.

@@ -22,6 +22,7 @@
*
* @param eventType The type of event.
* @param attributes The key-value pairs that make up the event.
* @param timestamp time stamp in epoch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

millis?

Copy link
Contributor

@breedx-nr breedx-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's just change that one timestamp to clarify units. Thanks again!

@breedx-nr
Copy link
Contributor

(Also needs a rebase)

@uaihebert uaihebert force-pushed the 226-clean-up-javadoc-warning-telemetry-core branch from 0799884 to d63b5e1 Compare October 5, 2020 21:32
@uaihebert uaihebert force-pushed the 226-clean-up-javadoc-warning-telemetry-core branch from d63b5e1 to 2141fbc Compare October 5, 2020 21:34
@uaihebert
Copy link
Contributor Author

all done. ( :

@breedx-nr
Copy link
Contributor

Thanks again @uaihebert !

@breedx-nr breedx-nr merged commit c6a466b into newrelic:main Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix javadoc warnings in telemetry_core
2 participants