Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update BatchDataSender to show the cause of IOException #294

Merged
merged 2 commits into from Jul 15, 2022

Conversation

vinicius-roc
Copy link
Contributor

@vinicius-roc vinicius-roc commented Jul 14, 2022

BatchDataSender was updated to show the cause of IOException.

In my scenario, when I try to send a metrics to new relic i received the below message.

WARN transport.BatchDataSender: IOException (message: Error posting metrics to New Relic) while trying to send data to New Relic. MetricBatch retry recommended

When i look for root cause of IOException, i found MicrometerHttpPoster that encapsule the original cause inside IOException

try {
  ...
} catch (Throwable th) {
  throw new IOException("Error posting metrics to New Relic", th);
}

So, to be able to see the root cause, I added to message

@CLAassistant
Copy link

CLAassistant commented Jul 14, 2022

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants