Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proxy support. #30

Merged
merged 3 commits into from
Jun 5, 2020
Merged

Add proxy support. #30

merged 3 commits into from
Jun 5, 2020

Conversation

BrandonTheBuilder
Copy link

This PR adds support for sending data to Newrelic via a proxy.

Closes: #17

@BrandonTheBuilder BrandonTheBuilder requested a review from a team as a code owner June 5, 2020 15:15
@a-feld a-feld self-assigned this Jun 5, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2020

Codecov Report

Merging #30 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #30   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          302       322   +20     
  Branches        23        26    +3     
=========================================
+ Hits           302       322   +20     
Impacted Files Coverage Δ
src/newrelic_telemetry_sdk/client.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a3ec1b...7a291a3. Read the comment docs.

Copy link
Contributor

@a-feld a-feld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@a-feld a-feld merged commit 2f4a02c into master Jun 5, 2020
@a-feld a-feld deleted the add-proxy-support branch June 5, 2020 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for proxy
3 participants