Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Removed use_new_release input from prepare release workflow #247

Merged

Conversation

svetlanabrennan
Copy link
Contributor

@svetlanabrennan svetlanabrennan commented Apr 4, 2024

Description

We no longer need to use use_new_release input variable in the prepare release workflow since that will be the only option. Also added changelog_file input since it was missing.

Related Issues

Related to: newrelic/node-newrelic#2124
Partially fixes: newrelic/node-newrelic#2113

ToDo

  • Remove USE_NEW_RELEASE from github action variables

@svetlanabrennan svetlanabrennan added the dev:automation Indicates CI automation label Apr 4, 2024
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.81%. Comparing base (aa63ee8) to head (74a75f2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #247   +/-   ##
=======================================
  Coverage   97.81%   97.81%           
=======================================
  Files           1        1           
  Lines         183      183           
=======================================
  Hits          179      179           
  Misses          4        4           
Flag Coverage Δ
integration-tests-16-ubuntu-latest-x64 85.24% <ø> (ø)
integration-tests-16-windows-latest-x64 85.24% <ø> (ø)
integration-tests-16-windows-latest-x86 85.24% <ø> (ø)
integration-tests-18-ubuntu-latest-x64 84.15% <ø> (ø)
integration-tests-18-windows-latest-x64 84.15% <ø> (ø)
integration-tests-18-windows-latest-x86 84.15% <ø> (ø)
integration-tests-20-ubuntu-latest-x64 84.15% <ø> (ø)
integration-tests-20-windows-latest-x64 84.15% <ø> (ø)
integration-tests-20-windows-latest-x86 84.15% <ø> (ø)
unit-tests-16-macos-14-arm64 93.44% <ø> (ø)
unit-tests-16-ubuntu-latest-x64 93.44% <ø> (ø)
unit-tests-16-windows-latest-x64 93.44% <ø> (ø)
unit-tests-16-windows-latest-x86 93.44% <ø> (ø)
unit-tests-18-macos-14-arm64 92.34% <ø> (ø)
unit-tests-18-ubuntu-latest-x64 92.34% <ø> (ø)
unit-tests-18-windows-latest-x64 92.34% <ø> (ø)
unit-tests-18-windows-latest-x86 92.34% <ø> (ø)
unit-tests-20-macos-14-arm64 92.34% <ø> (?)
unit-tests-20-ubuntu-latest-x64 92.34% <ø> (ø)
unit-tests-20-windows-latest-x64 92.34% <ø> (ø)
unit-tests-20-windows-latest-x86 92.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@svetlanabrennan svetlanabrennan changed the title ci: Removed use_new_release input from prepare release workflow ci: Removed use_new_release input from prepare release workflow Apr 4, 2024
@svetlanabrennan svetlanabrennan merged commit 6cadc52 into newrelic:main Apr 4, 2024
20 checks passed
Node.js Engineering Board automation moved this from Needs PR Review to Done: Issues recently completed Apr 4, 2024
@github-actions github-actions bot mentioned this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev:automation Indicates CI automation
Projects
Node.js Engineering Board
  
Done: Issues recently completed
Development

Successfully merging this pull request may close these issues.

Remove use_new_release in every repo prep release workflow
2 participants