Skip to content
This repository has been archived by the owner on May 20, 2024. It is now read-only.

3.363.0 breaks v3 instrumentation #194

Closed
bizob2828 opened this issue Jun 29, 2023 · 1 comment · Fixed by #195
Closed

3.363.0 breaks v3 instrumentation #194

bizob2828 opened this issue Jun 29, 2023 · 1 comment · Fixed by #195
Assignees
@bizob2828
Labels
bug
Projects
Node.js Engineering Board

Comments

@bizob2828
Copy link
Member

It looks like they renamed the smithy-client packages from @aws-sdk/smithy-client to @smithy/smithy-client in 3.363.0. This is causing all of our instrumentation to lack aws attributes on spans and tracking the external calls.

Notes:
I make a slight tweak and still have some failing tests to triage.
@workato-integration
Copy link

https://issues.newrelic.com/browse/NR-139974

@bizob2828 bizob2828 self-assigned this Jun 29, 2023
@newrelic-node-agent-team newrelic-node-agent-team added this to Triage Needed: Unprioritized Features in Node.js Engineering Board Jun 29, 2023
@bizob2828 bizob2828 changed the title 3.363.0 breaks our instrumentation 3.363.0 breaks v3 instrumentation Jun 29, 2023
@bizob2828 bizob2828 moved this from Triage Needed: Unprioritized Features to In progress: Issues being worked on in Node.js Engineering Board Jun 30, 2023
@bizob2828 bizob2828 mentioned this issue Jun 30, 2023
Merged
Node.js Engineering Board automation moved this from In progress: Issues being worked on to Done: Issues recently completed Jun 30, 2023
@Fortiz2305 Fortiz2305 mentioned this issue Jul 17, 2023
Closed
@dyladan dyladan mentioned this issue Jul 19, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bizob2828 bizob2828

Labels
bug
Projects
Node.js Engineering Board
  
Done: Issues recently completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix instrumentation in 3.363.0 of aws sdk bizob2828/node-newrelic-aws-sdk
1 participant
@bizob2828