Skip to content
This repository has been archived by the owner on May 20, 2024. It is now read-only.

Fix instrumentation in 3.363.0 of aws sdk #195

Merged
merged 1 commit into from Jun 30, 2023

Conversation

bizob2828
Copy link
Member

Proposed Release Notes

  • Fixed instrumentation in AWS 3.363.0.

Links

Closes #194

Details

AWS decided to rename their smithy client package to be @smithy scoped. Thankfully this was a quick fix.

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #195 (77593d3) into main (55ac220) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #195      +/-   ##
==========================================
+ Coverage   95.66%   95.69%   +0.02%     
==========================================
  Files          15       15              
  Lines         946      952       +6     
==========================================
+ Hits          905      911       +6     
  Misses         41       41              
Flag Coverage Δ
unit-tests-14.x 3.88% <0.00%> (-0.03%) ⬇️
unit-tests-16.x 3.88% <0.00%> (-0.03%) ⬇️
unit-tests-18.x 3.88% <0.00%> (-0.03%) ⬇️
versioned-tests-14.x 95.69% <100.00%> (+0.02%) ⬆️
versioned-tests-16.x 95.69% <100.00%> (+0.02%) ⬆️
versioned-tests-18.x ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nr-hooks.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@jmartin4563 jmartin4563 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@bizob2828 bizob2828 merged commit 639041c into newrelic:main Jun 30, 2023
13 checks passed
Node.js Engineering Board automation moved this from Needs PR Review to Done: Issues recently completed Jun 30, 2023
This was referenced Jun 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Node.js Engineering Board
  
Done: Issues recently completed
Development

Successfully merging this pull request may close these issues.

3.363.0 breaks v3 instrumentation
2 participants