Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify undici instrumentation and remove feature flags #1771

Closed
bizob2828 opened this issue Aug 31, 2023 · 2 comments · Fixed by #1772
Closed

Simplify undici instrumentation and remove feature flags #1771

bizob2828 opened this issue Aug 31, 2023 · 2 comments · Fixed by #1772

Comments

@bizob2828
Copy link
Member

bizob2828 commented Aug 31, 2023

Description

We have feature flags gating undici. It's also making instrumenting global fetch more difficult because it'd require users to enable the undici feature flag as fetch is just undici under the hood.

Acceptance Criteria

As a New Relic Node.js customer I want the ability to track undici requests as external calls.

@workato-integration
Copy link

@newrelic-node-agent-team newrelic-node-agent-team added this to Triage Needed: Unprioritized Features in Node.js Engineering Board Aug 31, 2023
@bizob2828 bizob2828 self-assigned this Aug 31, 2023
@bizob2828
Copy link
Member Author

Turns out the patch solves some issues and creates others around the span relationship of concurrent undici requests. If keep alive in enabled they're broken but you can disable the undici_async_tracking feature flag. We will keep this flag and just remove the undici feature flag.

@bizob2828 bizob2828 moved this from Triage Needed: Unprioritized Features to Needs PR Review in Node.js Engineering Board Aug 31, 2023
Node.js Engineering Board automation moved this from Needs PR Review to Done: Issues recently completed Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Node.js Engineering Board
  
Done: Issues recently completed
1 participant