Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Removed undici feature flag. This will now instrument undici by default #1772

Merged
merged 1 commit into from Sep 1, 2023

Conversation

bizob2828
Copy link
Member

Description

I was hoping to remove the undici_async_tracking feature flag but there is still some inconsistency with async context propagation. This will need to be addressed in undici itself. I think I plan on PRing that shortly so that we can remove this feature flag at a later date.

Links

Closes #1771

@mrickard mrickard self-assigned this Aug 31, 2023
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #1772 (f30c62a) into main (3f494f8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1772   +/-   ##
=======================================
  Coverage   96.83%   96.83%           
=======================================
  Files         198      198           
  Lines       38747    38734   -13     
=======================================
- Hits        37520    37510   -10     
+ Misses       1227     1224    -3     
Flag Coverage Δ
integration-tests-16.x 79.04% <100.00%> (ø)
integration-tests-18.x 79.05% <100.00%> (+<0.01%) ⬆️
integration-tests-20.x 79.06% <100.00%> (ø)
unit-tests-16.x 91.39% <100.00%> (+<0.01%) ⬆️
unit-tests-18.x 91.37% <100.00%> (+<0.01%) ⬆️
unit-tests-20.x 91.37% <100.00%> (+<0.01%) ⬆️
versioned-tests-16.x 75.56% <100.00%> (-0.04%) ⬇️
versioned-tests-18.x 75.56% <100.00%> (-0.04%) ⬇️
versioned-tests-20.x 75.57% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
lib/feature_flags.js 100.00% <100.00%> (ø)
lib/instrumentation/undici.js 99.11% <100.00%> (+1.20%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bizob2828 bizob2828 changed the title feat: Removed undici feature flag. This will not instrument undici by default feat: Removed undici feature flag. This will now instrument undici by default Sep 1, 2023
@bizob2828 bizob2828 merged commit 683b254 into newrelic:main Sep 1, 2023
24 checks passed
Node.js Engineering Board automation moved this from Needs PR Review to Done: Issues recently completed Sep 1, 2023
@github-actions github-actions bot mentioned this pull request Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Node.js Engineering Board
  
Done: Issues recently completed
Development

Successfully merging this pull request may close these issues.

Simplify undici instrumentation and remove feature flags
2 participants