Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core module domain registered as third-party #1860

Closed
mrickard opened this issue Nov 10, 2023 · 1 comment · Fixed by #1883
Closed

Core module domain registered as third-party #1860

mrickard opened this issue Nov 10, 2023 · 1 comment · Fixed by #1883

Comments

@mrickard
Copy link
Member

Shimmer historically treats the domain module as third-party instrumentation to be lazy-loaded. This is now causing a logged error when the agent attempts to load the nonexistent ./package.json of the core domain module.

Description

Version 11 of the agent uses require-in-the-middle (or import-in-the-middle for ESM); differences in behavior may have eliminated the need to separate out the domain module the way the agent had traditionally done.

Expected Behavior

domain recognized as a core module, with no attempt to load ./package.json.

@workato-integration
Copy link

@newrelic-node-agent-team newrelic-node-agent-team added this to Triage Needed: Unprioritized Features in Node.js Engineering Board Nov 10, 2023
Node.js Engineering Board automation moved this from Triage Needed: Unprioritized Features to Done: Issues recently completed Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Node.js Engineering Board
  
Done: Issues recently completed
1 participant