feat: Added pkgVersion to shim instances to facilitate semver checking without having to re-parse the package.json #1883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g without having to re-parse the package.json
bizob2828
force-pushed
the
shim-version
branch
from
0546be0
to
3afd5ad
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1883 +/- ##
==========================================
- Coverage 96.87% 96.87% -0.01%
==========================================
Files 209 209
Lines 39635 39699 +64
==========================================
+ Hits 38397 38458 +61
- Misses 1238 1241 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Node.js Engineering Board
automation
moved this from Needs PR Review
to Done: Issues recently completed
Nov 21, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #1799 we added parsing package.json to all packages getting instrumented in shimmer. There were a few places where it was later parsing package.json. This PR assigns the pkgVersion to the shim instance so it can be read in instrumentation instead of re-parsing package.json. The longer term goal will be to build semver checking into instrumentation registration but that's for another PR. This also reduces re-parsing package.json to track instrumentation usage as it's on the shim instance.
Related Issues
This actually closes #1860 because it does not try to parse package.json any longer.