Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide ability to send common events #1981

Closed
bizob2828 opened this issue Jan 29, 2024 · 1 comment · Fixed by #1994
Closed

Provide ability to send common events #1981

bizob2828 opened this issue Jan 29, 2024 · 1 comment · Fixed by #1994

Comments

@bizob2828
Copy link
Member

bizob2828 commented Jan 29, 2024

Description

The APM Agent teams are often asked to add support for a new type of data (ex: log events) that will be sent to a new method on the collector. This implementation typically involves duplicating a set of logic so that the new data type has its own record_ function that creates a record of the new data type, list/queue/aggregator for the data to be sent, configuration for tuning how much information to hold before sampling, configuration for how often to harvest the data, and logic to actually harvest the new list/queue/aggregator data on the correct intervals.

Instead of cloning the logic required to support a new data type sent to a new collector method (build the list/queue/aggregator, configuration, harvester, etc) the proposal is to build application logic that would allow defining a new type of custom event with its own configuration, list/queue/aggregator, and harvester. It is a subtle distinction in that most of the effort is the same. The key difference is that this agent implementation should allow agents to support a new category of event in the future that has it’s own sampling rate with minimal future changes to the agent required to support that new category.

Acceptance Criteria

As an agent engineer, it should be clear on how to add a new aggregator and all the necessary logic for it to function

Additional context

This is a recent-ish PR that implemented a new aggregator and all the necessary plumbing to enqueue and send a new type of events.

@workato-integration
Copy link

@newrelic-node-agent-team newrelic-node-agent-team added this to Triage Needed: Unprioritized Features in Node.js Engineering Board Jan 29, 2024
@bizob2828 bizob2828 self-assigned this Jan 29, 2024
@bizob2828 bizob2828 moved this from Triage Needed: Unprioritized Features to In progress: Issues being worked on in Node.js Engineering Board Jan 29, 2024
@bizob2828 bizob2828 moved this from In progress: Issues being worked on to Needs PR Review in Node.js Engineering Board Feb 1, 2024
Node.js Engineering Board automation moved this from Needs PR Review to Done: Issues recently completed Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Node.js Engineering Board
  
Done: Issues recently completed
1 participant