test: Updated smoke tests to send data to the appropriate collector method #2005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsumners-nr
approved these changes
Feb 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2005 +/- ##
=======================================
Coverage 97.07% 97.07%
=======================================
Files 225 225
Lines 40490 40490
=======================================
Hits 39307 39307
Misses 1183 1183
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Node.js Engineering Board
automation
moved this from Needs PR Review
to Done: Issues recently completed
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1981 refactored the collector to have a common send function and the first argument is now the method on collector API. Smoke tests apparently used this directly and needed to be updated to use the send function instead of the specific collector method as function name. I also pushed my branch to the origin so the smoke tests should run and pass now