Create postgres.js

[brianc]

Placeholder file to begin discussion/work for adding node-postgres instrumentation.

[brianc]

I'm happy to help out on this any way I can. 😄

[cdnbacon]

Woohoo! Happy to lend a hand as well. Was just poking around to see how the MySQL version was implemented. I'd love to see this happen (or make it happen), since I've been spoiled with seeing traces for Ruby+PG in new relic, and now my traces for Node leave me wanting more...

@groundwater do we just need to get inspired by https://github.com/newrelic/node-newrelic/blob/master/lib/instrumentation/mysql.js, or is there more secret sauce necessary?

[groundwater]

@cdnbacon yes, if you want to take a stab at it, the mysql.js instrumentation file is a great place to start looking.

The key thing to know is that our out transaction tracer uses the continuation-local-storage module to pass state between async requests. Connection pooling causes state to get lost, so you'll need to use .bind from the CLS module. If it gets hairy @wraithan and I can definitely help you out along the way.

This is also on our roadmap, but not immediately.

Thank you for the help!

[cdnbacon]

@groundwater is there a vagrant box or docker image we can use to test? I was looking through the contributing guidelines and it seems there are quite a few services to kick off to get them running...

[groundwater]

@cdnbacon that's a totally reasonable request, but unfortunately not yet. You don't need any services running, the tests take care of that themselves. You just need the executable on your PATH.

I won't be merging with the big green button in any case, so if you break something else it's not the end of the world. Best effort works for me 👍

[wraithan]

A thing to note is that the file needs to be named the same as the module name. So it will be need to be pg.js. Aside from that mysql.js will be a decent starting point, feel free to ping me on here or on irc.freenode.net with any questions you have.

[jwhitehorn]

👍 This is literally the only thing keeping me from upgrading my New Relic subscription.