fix: Updated mysql instrumentation to properly wrap the connection pool.getConnection and poolCluster.of #1647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bizob2828
changed the title
Signed-off-by: mrickard <maurice@mauricerickard.com>
…ypos Signed-off-by: mrickard <maurice@mauricerickard.com>
Signed-off-by: mrickard <maurice@mauricerickard.com>
Signed-off-by: mrickard <maurice@mauricerickard.com>
…asic-pool.tap.js Signed-off-by: mrickard <maurice@mauricerickard.com>
…re closely with mysql/basic-pool.tap.js Signed-off-by: mrickard <maurice@mauricerickard.com>
…n uses a non-pooled connection Signed-off-by: mrickard <maurice@mauricerickard.com>
Signed-off-by: mrickard <maurice@mauricerickard.com>
Codecov Report
@@ Coverage Diff @@
## main #1647 +/- ##
==========================================
+ Coverage 96.23% 96.64% +0.41%
==========================================
Files 199 200 +1
Lines 39028 39065 +37
Branches 9 24 +15
==========================================
+ Hits 37557 37756 +199
+ Misses 1470 1309 -161
+ Partials 1 0 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jmartin4563
suggested changes
May 23, 2023
…pool.tap.js files Signed-off-by: mrickard <maurice@mauricerickard.com>
Signed-off-by: mrickard <maurice@mauricerickard.com>
jmartin4563
approved these changes
May 23, 2023
Node.js Engineering Board
automation
moved this from Needs PR Review
to Done: Issues recently completed
May 23, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note: We need to add more information to the commit description on squash and merge to call out the fact we also instrument Poolnamespace.prototype.query now too.
This PR fixes the
setuphelper method in mysql by running before the agent instrumentation is loaded and busts the require cache. This was found to hide the root cause of this PR which was a mistake on a symbol defaulting to true. By fixing setup it also exposed an issue with PoolNamespace.prototype.query where it isn't getting instrumented thus some failing tests.How to Test
Restore this bit flip, and the tests should fail
Related Issues
Closes #1645