feat: Load IAST security agent when security.agent.enabled is true #1664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….agent.enabled is true
…ning in security agent
configuration that was agreed upon.
…ection not array of onRequire, onResolved, onError hooks. For every instrumentation you will get a unique shim instance unless you specify `shimName` which will store a reference to a shim instance that can be shared(koa needs this as the modules layer instrumentation on itself).
…code to functions, use optional chaining for deep access of keys on objects
…adds a new api.getLinkingMetadata call
…unction on the original symbol or current object
…ly a wrapped callback to make sure it is not wrapped more than once
Codecov Report
@@ Coverage Diff @@
## main #1664 +/- ##
==========================================
+ Coverage 96.76% 96.79% +0.02%
==========================================
Files 200 200
Lines 39148 39178 +30
Branches 24 24
==========================================
+ Hits 37883 37921 +38
+ Misses 1265 1257 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bizob2828
commented
Jun 7, 2023
| ? 14 | ||
| : 15 | ||
| : 7 | ||
| console.log(Object.keys(metrics)) |
bizob2828
commented
Jun 7, 2023
bizob2828
commented
Jun 7, 2023
bizob2828
commented
Jun 7, 2023
bizob2828
commented
Jun 7, 2023
jmartin4563
suggested changes
Jun 12, 2023
There was a problem hiding this comment.
I tested this locally by running the versioned tests for the security agent. Additionally, I setup an ESM express app with no vulnerabilities and the security agent turned on as a sanity check (there were no issues seeing data in the ui), if you would like me to test with a vulnerability, I can update my app to confirm that vulnerability shows up in ESM.
bizob2828
changed the title
jmartin4563
approved these changes
Jun 12, 2023
Node.js Engineering Board
automation
moved this from Needs PR Review
to Done: Issues recently completed
Jun 12, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR has been the staging branch for all things security agent related. Some things to highlight:
security.agent.enabledis true@newrelic/security-agent. This will prob pin the agent for the foreseeable futureHow to Test
npm run versioned:security:majorornpm run versioned:security