chore: Added test for getRedisParams #1670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mrickard <maurice@mauricerickard.com>
Codecov Report
@@ Coverage Diff @@
## main #1670 +/- ##
==========================================
+ Coverage 96.76% 96.79% +0.02%
==========================================
Files 200 200
Lines 39148 39180 +32
Branches 24 24
==========================================
+ Hits 37883 37923 +40
+ Misses 1265 1257 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bizob2828
approved these changes
Jun 14, 2023
And I ended up finding one scenario which would have thrown when it didn't have to. |
Node.js Engineering Board
automation
moved this from Needs PR Review
to Done: Issues recently completed
Jun 14, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added tests for the different branches of getRedisParams
Related Issues
Closes #1242
Closes NEWRELIC-4440