chore(testing): convert query-test-aggregator tests to tap style #1676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node 14 can't handle latest nest.js release
Codecov Report
@@ Coverage Diff @@
## main #1676 +/- ##
==========================================
- Coverage 96.87% 96.85% -0.03%
==========================================
Files 200 200
Lines 39178 39180 +2
Branches 24 24
==========================================
- Hits 37953 37947 -6
- Misses 1225 1233 +8
Flags with carried forward coverage won't be shown. Click here to find out more. see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jordigh
force-pushed
the
demochaify-query-tracer
branch
from
7f9f338
to
4f18c23
Compare
Our instrumentation changed across these minor versions, so running versioned tests with a `--minor` flag won't test both sides of the instrumentation across these minor versions. So explicitly make a break in the version numbers defined in the tests to ensure that these different minor version numbers are tested.
jordigh
force-pushed
the
demochaify-query-tracer
branch
from
4f18c23
to
751ddfb
Compare
mrickard
reviewed
Jun 16, 2023
mrickard
approved these changes
Jun 16, 2023
Node.js Engineering Board
automation
moved this from Needs PR Review
to Done: Issues recently completed
Jun 16, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Fixes #1675