feat!: Renamed shim.handleCATHeaders to shim.handleMqTracingHeaders #1735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mrickard <maurice@mauricerickard.com>
Codecov Report
@@ Coverage Diff @@
## main #1735 +/- ##
==========================================
+ Coverage 96.87% 96.88% +0.01%
==========================================
Files 200 200
Lines 39181 39210 +29
Branches 24 22 -2
==========================================
+ Hits 37956 37989 +33
+ Misses 1225 1221 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bizob2828
changed the title
bizob2828
approved these changes
Aug 16, 2023
|
I will merge this to ensure we include the commit body with more context for the changelog |
Node.js Engineering Board
automation
moved this from Needs PR Review
to Done: Issues recently completed
Aug 16, 2023
This was referenced Aug 21, 2023
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Renamed handleCATHeaders to handleMqTracingHeaders. This function handles both distributed tracing and cross-application-tracing headers for message queues. CAT is going to be removed, leaving just the DT functionality.
How to Test
test/unit/ship/transaction-shim.test.js covers this file.
Related Issues
Closes #903
Closes NR-133499