chore: fixed typos in lib/config/index.js comments #1749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1749 +/- ##
==========================================
+ Coverage 96.85% 96.88% +0.03%
==========================================
Files 200 200
Lines 39220 39220
Branches 22 22
==========================================
+ Hits 37987 37999 +12
+ Misses 1233 1221 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@brnhensley feel free to fix more spelling mistakes. Those aren't on purpose it's just they work because of our IDEs making sure the function names match |
bizob2828
approved these changes
Aug 3, 2023
bizob2828
changed the title
Node.js Engineering Board
automation
moved this from Needs PR Review
to Done: Issues recently completed
Aug 3, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is nothing but typo corrections. Only one in a log line, the rest in code comments. There are no functional changes.
I checked that the two typos that directly reference the code (
process_host.ipv_preferenceandthis.serverless_mode) are only misspelled in the comment, the code itself is using the correct spelling I changed them to.I was temped to rename
_laspReponseto_laspResponse, but I didn't want to step on any toes. Though it looks like it's only in the repo in this file and would be a safe change.