Log the actual error for config not being read #178
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seriously newrelic, you need to merge this pull request. Throwing away error here masks errors and kills time. I was banging my head googling for an hour before I finally decided to put some debug prints in your module and got the real error (that I had missed a comma in newrelic.js). There have to be some people who just give up when they're told a file doesn't exists and it clearly does so you're probably losing some customers. |
|
👍 |
|
I'll try to get this released this week. Sorry for the delay. |
|
1.14.6 contains this patch. Thanks! |
jsumners-nr
pushed a commit
to jsumners-nr/node-newrelic
that referenced
this pull request
Apr 16, 2024
bizob2828
pushed a commit
to bizob2828/node-newrelic
that referenced
this pull request
Apr 19, 2024
…rkflow Fix presigned url workflow
bizob2828
pushed a commit
to bizob2828/node-newrelic
that referenced
this pull request
Apr 23, 2024
…rkflow Fix presigned url workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically it's impossible to debug, especially if the error only happens in a Docker container (which it is, for me).