feat: Added instrumentation for ElasticSearch #1785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrickard
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1785 +/- ##
==========================================
+ Coverage 96.84% 96.85% +0.01%
==========================================
Files 198 199 +1
Lines 38755 38901 +146
==========================================
+ Hits 37531 37677 +146
Misses 1224 1224
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bizob2828
requested changes
Sep 18, 2023
bizob2828
requested changes
Sep 20, 2023
bizob2828
reviewed
Sep 20, 2023
mrickard
commented
Sep 20, 2023
mrickard
force-pushed
the
NR-150258/support-elasticsearch
branch
2 times, most recently
from
6e2a355
to
a854997
Compare
bizob2828
reviewed
Sep 22, 2023
|
|
||
| const suffix = actions[params.method] | ||
| path.forEach((segment, idx) => { | ||
| const prev = idx - 1 |
There was a problem hiding this comment.
I worry that someone could create an index as _search or name an index with _. In that case we're naming the collection any. It appears that's not allowed but we aren't handling that at all
There was a problem hiding this comment.
Yeah, it's explicitly prohibited for path index names to start with _, -, or +, and for path parameters to include /, among other punctuation characters. https://www.elastic.co/guide/en/elasticsearch/reference/current/indices-create-index.html
There was a problem hiding this comment.
OK--I've updated that to handle index creation separately.
Signed-off-by: mrickard <maurice@mauricerickard.com>
Signed-off-by: mrickard <maurice@mauricerickard.com>
Signed-off-by: mrickard <maurice@mauricerickard.com>
Signed-off-by: mrickard <maurice@mauricerickard.com>
…om connect to request, fixed calling the inContext method by calling with ctx instead of bind
Signed-off-by: mrickard <maurice@mauricerickard.com>
Signed-off-by: mrickard <maurice@mauricerickard.com>
…metric host name assertions Signed-off-by: mrickard <maurice@mauricerickard.com>
Signed-off-by: mrickard <maurice@mauricerickard.com>
Signed-off-by: mrickard <maurice@mauricerickard.com>
Signed-off-by: mrickard <maurice@mauricerickard.com>
Signed-off-by: mrickard <maurice@mauricerickard.com>
Signed-off-by: mrickard <maurice@mauricerickard.com>
Signed-off-by: mrickard <maurice@mauricerickard.com>
Signed-off-by: mrickard <maurice@mauricerickard.com>
Signed-off-by: mrickard <maurice@mauricerickard.com>
Signed-off-by: mrickard <maurice@mauricerickard.com>
Signed-off-by: mrickard <maurice@mauricerickard.com>
Signed-off-by: mrickard <maurice@mauricerickard.com>
mrickard
force-pushed
the
NR-150258/support-elasticsearch
branch
from
3afaa55
to
685e9ce
Compare
bizob2828
requested changes
Sep 25, 2023
…ndex creation without manipulating index name. Signed-off-by: mrickard <maurice@mauricerickard.com>
Signed-off-by: mrickard <maurice@mauricerickard.com>
…ntained Signed-off-by: mrickard <maurice@mauricerickard.com>
Node.js Engineering Board
automation
moved this from Needs PR Review
to Done: Issues recently completed
Oct 2, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for ElasticSearch instrumentation, for v8.0 and up
How to Test
npm run versioned elasticnpm run unitto pick up unit tests around the query parser.Related Issues
Closes #1757
Closes NR-150258