Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updated dev dep get-func-name to fix CVE #1790

Merged
merged 1 commit into from Oct 3, 2023

Conversation

bizob2828
Copy link
Member

Description

While testing something else I noticed a dep of chai has a CVE. This is a dev dep so not a big deal but want this updated.

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #1790 (f8e4f66) into main (9ca78ae) will increase coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1790      +/-   ##
==========================================
+ Coverage   96.84%   96.85%   +0.01%     
==========================================
  Files         198      199       +1     
  Lines       38755    38901     +146     
==========================================
+ Hits        37531    37677     +146     
  Misses       1224     1224              
Flag Coverage Δ
integration-tests-16.x 78.85% <100.00%> (+<0.01%) ⬆️
integration-tests-18.x 79.12% <100.00%> (+<0.01%) ⬆️
integration-tests-20.x 79.14% <100.00%> (+0.01%) ⬆️
unit-tests-16.x 91.38% <85.61%> (-0.03%) ⬇️
unit-tests-18.x 91.36% <85.61%> (-0.03%) ⬇️
unit-tests-20.x 91.36% <85.61%> (-0.03%) ⬇️
versioned-tests-16.x 75.60% <93.83%> (-0.02%) ⬇️
versioned-tests-18.x 75.59% <93.83%> (-0.02%) ⬇️
versioned-tests-20.x 75.61% <93.83%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
lib/instrumentation/@elastic/elasticsearch.js 100.00% <100.00%> (ø)
lib/instrumentations.js 100.00% <100.00%> (ø)
lib/shim/datastore-shim.js 99.41% <100.00%> (+<0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bizob2828 bizob2828 merged commit f378c77 into newrelic:main Oct 3, 2023
25 checks passed
Node.js Engineering Board automation moved this from Needs PR Review to Done: Issues recently completed Oct 3, 2023
mrickard added a commit to mrickard/node-newrelic that referenced this pull request Oct 3, 2023
* chore: updated dev dep get-func-name to fix CVE (newrelic#1790)

* fix: Adjusting elastic versioned test timeout

Signed-off-by: mrickard <maurice@mauricerickard.com>

---------

Signed-off-by: mrickard <maurice@mauricerickard.com>
Co-authored-by: Bob Evans <revans@newrelic.com>
@github-actions github-actions bot mentioned this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Node.js Engineering Board
  
Done: Issues recently completed
Development

Successfully merging this pull request may close these issues.

None yet

2 participants