Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add steps to zip up container logs on versioned test failure #1804

Merged
merged 1 commit into from Oct 10, 2023

Conversation

bizob2828
Copy link
Member

@bizob2828 bizob2828 commented Oct 10, 2023

I would've been able to triage the elastic search issues faster if we had logs for the container. This PR uploads all docker logs if a versioned test run fails.

You can see links here. I had a commit that replaced failure() with always(), but this will work on failures.

You can see there is a .gz for every version.

screenshot 2023-10-10 at 5 05 32 PM

@mrickard mrickard self-assigned this Oct 10, 2023
@bizob2828 bizob2828 added the dev:automation Indicates CI automation label Oct 10, 2023
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #1804 (48023e4) into main (9ca78ae) will decrease coverage by 0.02%.
Report is 7 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1804      +/-   ##
==========================================
- Coverage   96.84%   96.82%   -0.02%     
==========================================
  Files         198      199       +1     
  Lines       38755    38958     +203     
==========================================
+ Hits        37531    37723     +192     
- Misses       1224     1235      +11     
Flag Coverage Δ
integration-tests-16.x 78.91% <93.98%> (+0.05%) ⬆️
integration-tests-18.x 79.19% <93.98%> (+0.06%) ⬆️
integration-tests-20.x 79.18% <93.98%> (+0.05%) ⬆️
unit-tests-16.x 91.43% <92.05%> (+0.02%) ⬆️
unit-tests-18.x 91.41% <92.05%> (+0.02%) ⬆️
unit-tests-20.x 91.41% <92.05%> (+0.02%) ⬆️
versioned-tests-16.x 73.06% <86.85%> (-2.55%) ⬇️
versioned-tests-18.x 73.06% <86.85%> (-2.55%) ⬇️
versioned-tests-20.x 72.97% <77.57%> (-2.66%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
api.js 96.14% <100.00%> (+<0.01%) ⬆️
index.js 100.00% <100.00%> (ø)
lib/instrumentation/@elastic/elasticsearch.js 100.00% <100.00%> (ø)
lib/instrumentations.js 100.00% <100.00%> (ø)
lib/shim/datastore-shim.js 99.41% <100.00%> (+<0.01%) ⬆️
lib/shimmer.js 94.46% <100.00%> (+2.11%) ⬆️

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bizob2828 bizob2828 merged commit 0a54729 into newrelic:main Oct 10, 2023
28 of 29 checks passed
Node.js Engineering Board automation moved this from Needs PR Review to Done: Issues recently completed Oct 10, 2023
@github-actions github-actions bot mentioned this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev:automation Indicates CI automation
Projects
Node.js Engineering Board
  
Done: Issues recently completed
Development

Successfully merging this pull request may close these issues.

None yet

2 participants