Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update release note headers to follow standard #1806

Merged
merged 2 commits into from Oct 12, 2023

Conversation

coreyarnold
Copy link
Member

@coreyarnold coreyarnold commented Oct 11, 2023

@bizob2828
Copy link
Member

we have unit tests for these scripts and they are failing. i can try to fix

@bizob2828 bizob2828 added the dev:automation Indicates CI automation label Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #1806 (55d24b1) into main (0a54729) will increase coverage by 0.00%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1806   +/-   ##
=======================================
  Coverage   96.82%   96.83%           
=======================================
  Files         199      199           
  Lines       38958    38959    +1     
=======================================
+ Hits        37723    37724    +1     
  Misses       1235     1235           
Flag Coverage Δ
integration-tests-16.x 78.94% <ø> (+0.03%) ⬆️
integration-tests-18.x 79.21% <ø> (+0.03%) ⬆️
integration-tests-20.x 79.22% <ø> (+0.02%) ⬆️
unit-tests-16.x 91.43% <ø> (+<0.01%) ⬆️
unit-tests-18.x 91.41% <ø> (+<0.01%) ⬆️
unit-tests-20.x 91.41% <ø> (+0.01%) ⬆️
versioned-tests-16.x 73.05% <ø> (-0.01%) ⬇️
versioned-tests-18.x 73.05% <ø> (-0.01%) ⬇️
versioned-tests-20.x 72.97% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bizob2828 bizob2828 merged commit 91d3600 into main Oct 12, 2023
49 checks passed
Node.js Engineering Board automation moved this from Needs PR Review to Done: Issues recently completed Oct 12, 2023
@bizob2828 bizob2828 deleted the coreyarnold-patch-1 branch October 12, 2023 15:57
This was referenced Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev:automation Indicates CI automation
Projects
Node.js Engineering Board
  
Done: Issues recently completed
Development

Successfully merging this pull request may close these issues.

None yet

2 participants