fix: Updated Elasticsearch instrumentation to only register on v7.13.0+ #1816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oop for earlier Signed-off-by: mrickard <maurice@mauricerickard.com>
bizob2828
requested changes
Oct 16, 2023
Codecov Report
@@ Coverage Diff @@
## main #1816 +/- ##
=======================================
Coverage 96.83% 96.83%
=======================================
Files 199 200 +1
Lines 38959 38994 +35
=======================================
+ Hits 37724 37759 +35
Misses 1235 1235
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mrickard
changed the title
…ve. Consolidated supported versioned tests to one file Signed-off-by: mrickard <maurice@mauricerickard.com>
Signed-off-by: mrickard <maurice@mauricerickard.com>
Signed-off-by: mrickard <maurice@mauricerickard.com>
Signed-off-by: mrickard <maurice@mauricerickard.com>
bizob2828
requested changes
Oct 17, 2023
…densed assignments Signed-off-by: mrickard <maurice@mauricerickard.com>
bizob2828
approved these changes
Oct 17, 2023
bizob2828
changed the title
Node.js Engineering Board
automation
moved this from Needs PR Review
to Done: Issues recently completed
Oct 17, 2023
This was referenced Oct 23, 2023
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added semver check to noop for ElasticSearch prior to v7.13.0.
Added defensive check on body and bulkBody params.
Added tests to verify ElasticSearch v7.13.0 and later coverage.
How to Test
npm run versioned elasticRelated Issues
Closes #1809
Closes NR-170194.