Replace Array.filter with Array.splice, to prevent the creation of a new...

[lmarkus]

... Array object. A new Array object might cause in-memory references to be lost, and potentially leak memory.

This should fix krakenjs/kraken-js#285

All tests passed using tap test/versioned/express*/*.tap.js except one because it coudn't connect to some Redis instance I don't have installed.

A more complete explanation of this can be found here:
https://github.com/lmarkus/newrelicbuster

[wraithan]

Thanks, we may want to add a test to make sure we don't replace the array in the future since kraken depends on that. Could also just add a kraken test that showed that this was a problem. We can write the tests, but wont happen this week probably. Or if you write them we should be able to merge it for release this week baring any other issues.

[lmarkus]

Unit test added.
Fails on the old code, passes on the patched code.
It's pretty straight forward.
Using express-enrouten (which is the actual Kraken module with the issue) try to load two routes.
The first one will always work, because the memory reference hasn't been removed yet.
The second route will not load on the current version, but will load with the patched code.

[wraithan]

@lmarkus thanks! Do you want to be in the release notes, and if so, how would you like to be attributed. Lots of folks use github username, others prefer full name, we are happy to attribute to you however you'd like.

[lmarkus]

Lenny Markus works for me.
Thanks!

[hayes]

released as 1.14.0