Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix bool -> boolean in jsdoc #1853

Merged
merged 1 commit into from Nov 7, 2023
Merged

Conversation

jsumners-nr
Copy link
Contributor

JSDoc doesn't recognize "bool" as a valid type. It should be written as "boolean". This PR adjusts all instances such that npm run lint does not report any "unknown type bool" errors.

JSDoc doesn't recognize "bool" as a valid type. It should be
written as "boolean". This PR adjusts all instances such that
`npm run lint` does not report any "unknown type bool" errors.
@CLAassistant
Copy link

CLAassistant commented Nov 7, 2023

CLA assistant check
All committers have signed the CLA.

@mrickard mrickard self-assigned this Nov 7, 2023
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #1853 (4b4f6ba) into main (fb06ac9) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1853   +/-   ##
=======================================
  Coverage   96.83%   96.83%           
=======================================
  Files         200      200           
  Lines       39073    39073           
=======================================
  Hits        37838    37838           
  Misses       1235     1235           
Flag Coverage Δ
integration-tests-16.x 78.97% <100.00%> (+0.02%) ⬆️
integration-tests-18.x 79.22% <100.00%> (+0.01%) ⬆️
integration-tests-20.x 79.23% <100.00%> (+0.01%) ⬆️
unit-tests-16.x 91.35% <100.00%> (ø)
unit-tests-18.x 91.33% <100.00%> (ø)
unit-tests-20.x 91.33% <100.00%> (+0.01%) ⬆️
versioned-tests-16.x 73.15% <100.00%> (-0.01%) ⬇️
versioned-tests-18.x 73.15% <100.00%> (-0.01%) ⬇️
versioned-tests-20.x 73.16% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
lib/adaptive-sampler.js 100.00% <100.00%> (ø)
lib/collector/remote-method.js 97.11% <100.00%> (ø)
lib/metrics/normalizer.js 97.63% <100.00%> (ø)
lib/metrics/normalizer/rule.js 100.00% <100.00%> (ø)
lib/shim/promise-shim.js 93.95% <100.00%> (ø)
lib/shim/shim.js 97.59% <100.00%> (ø)
lib/shim/transaction-shim.js 94.49% <100.00%> (ø)
lib/shim/webframework-shim.js 96.63% <100.00%> (ø)
lib/spans/streaming-span-event-aggregator.js 92.23% <100.00%> (ø)
lib/timer.js 98.26% <100.00%> (ø)
... and 4 more

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@jsumners-nr jsumners-nr merged commit 3c00e55 into newrelic:main Nov 7, 2023
26 checks passed
Node.js Engineering Board automation moved this from Needs PR Review to Done: Issues recently completed Nov 7, 2023
@jsumners-nr jsumners-nr deleted the bool-fix branch November 7, 2023 16:37
@github-actions github-actions bot mentioned this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Node.js Engineering Board
  
Done: Issues recently completed
Development

Successfully merging this pull request may close these issues.

None yet

3 participants