feat: Added openai LLM events. #1857
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1857 +/- ##
==========================================
+ Coverage 96.83% 96.85% +0.01%
==========================================
Files 200 206 +6
Lines 39074 39236 +162
==========================================
+ Hits 37839 38001 +162
Misses 1235 1235
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
| let agent | ||
| t.beforeEach(() => { | ||
| agent = helper.loadMockedAgent() | ||
| }) |
There was a problem hiding this comment.
As you mentioned in our call, defining agent this way technically makes it non-deterministic as to which instance is used by the subtests. But they run sequentially, so it's fine. But using t.context would assure the re-used variable is unique per subtest.
Not a blocker for me.
There was a problem hiding this comment.
yea this is a pattern all throughout our code. I guess it's a balance between consistency and correctness. Maybe we file some tech debt to remove saving references and relying on subtest context for passing data like this
bizob2828
force-pushed
the
llm-events
branch
from
3422336
to
1cc98f8
Compare
Description
I was able to confirm the data exists on the given request/responses when using a real openai library. I also removed
api_typeas it is not available. also updated CDD for how to get organizationLinks
Closes #1843