Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for official DataStax Cassandra driver #187

Closed
wants to merge 2 commits into from

Conversation

asilvas
Copy link
Contributor

@asilvas asilvas commented Dec 9, 2014

The old node-cassandra-cql driver has been deprecated, so this takes its place, and includes support for statement tracking as well (modeled after MySQL driver).

The build & test system is a little more involved for integration tests than I was prepared to dedicate at this time, so I did not touch that piece. The tests should pretty much mimic that of the existing node-cassandra-cql driver.

@wraithan
Copy link
Contributor

wraithan commented Dec 9, 2014

Howdy Aaron,

Thanks for writing this, unfortunately we wont be able to commit resources to this in the near term. With all instrumentation that gets sent as a PR we have to go through and learn the driver in an out in order to prove it works correctly in all cases. If you could provide tests, that would go a good distance into helping us, but even then I can't promise we'll immediately have time to review and merge.

Sorry to sound discouraging, we really do appreciate that you wrote this and would like to dedicate the time, but a good chunk of our team is busy with some cross team work that needs to happen. If I don't hear back from you before then, I'll make sure to update this ticket in a week or so on our availability to work on it.

@hayes
Copy link
Contributor

hayes commented Jan 6, 2015

Sorry for the lack of movement on this issue. We are working on a big refactor of our database instrumentation, and it does not make sense to try to add a new instrumentation until that has been released. I'll try to get this merged once our refactor is out.

@asilvas
Copy link
Contributor Author

asilvas commented Feb 26, 2015

Any eta?

@hayes
Copy link
Contributor

hayes commented Feb 26, 2015

We released our big refactor yesterday, I am trying to make some time to look into this today

@wraithan
Copy link
Contributor

Howdy, we totally forgot to close this out when we released support for the datastax driver. We added it in v1.17.1. I believe @hayes did a from scratch or copy from the node-cassandra-cql driver. He can go into further detail if needed.

@wraithan wraithan closed this Mar 17, 2015
bizob2828 added a commit to bizob2828/node-newrelic that referenced this pull request Apr 19, 2024
bizob2828 added a commit to bizob2828/node-newrelic that referenced this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants