feat: Added instrumentation for openai embedding creation #1872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bizob2828
force-pushed
the
embeddings
branch
from
80a66f5
to
ab97e04
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1872 +/- ##
==========================================
+ Coverage 96.85% 96.87% +0.01%
==========================================
Files 208 209 +1
Lines 39422 39573 +151
==========================================
+ Hits 38184 38335 +151
Misses 1238 1238
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Node.js Engineering Board
automation
moved this from Needs PR Review
to Done: Issues recently completed
Nov 16, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds instrumentation to create span for embedding creation and the LlmEmbedding event. I omitted opaque: true. I will update the chat complietion in a different PR. There is an ask to still capture the external http call to openai and this will do so. You can now see in the versioned tests that I'm asserting the child http external for embedding create.
Related Issues
Closes #1842