Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add streaming responses to mock OpenAI sever #1881

Merged
merged 2 commits into from Nov 20, 2023
Merged

test: Add streaming responses to mock OpenAI sever #1881

merged 2 commits into from Nov 20, 2023

Conversation

jsumners-nr
Copy link
Contributor

This PR adds streaming chat completion responses support to the mock OpenAI server.

@bizob2828 bizob2828 self-assigned this Nov 20, 2023
bizob2828
bizob2828 requested changes Nov 20, 2023
View reviewed changes
Copy link
Member

@bizob2828 bizob2828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified it's working aside from not including the appropriate spaces

test/lib/openai-mock-server.js Show resolved Hide resolved
bizob2828
bizob2828 approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@bizob2828 bizob2828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might have to update to handle errors but not a big deal, LGTM

@jsumners-nr jsumners-nr added the dev:tests Indicates only changes to tests label Nov 20, 2023
@jsumners-nr jsumners-nr merged commit 86d83f2 into newrelic:main Nov 20, 2023
22 checks passed
Node.js Engineering Board automation moved this from Needs PR Review to Done: Issues recently completed Nov 20, 2023
@jsumners-nr jsumners-nr deleted the oai-stream-mock branch November 20, 2023 17:04
@github-actions github-actions bot mentioned this pull request Nov 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bizob2828 bizob2828 bizob2828 approved these changes

Assignees

@bizob2828 bizob2828

Labels
dev:tests Indicates only changes to tests
Projects
Node.js Engineering Board
  
Done: Issues recently completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jsumners-nr @bizob2828