refactor: Fixed cognitive complexity violations of openai instrumentation by moving functions outside of the parent function scope #1895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion by moving functions outside of the parent function scope
jsumners-nr
previously approved these changes
Dec 4, 2023
jsumners-nr
approved these changes
Dec 4, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1895 +/- ##
=======================================
Coverage 96.87% 96.87%
=======================================
Files 209 209
Lines 39768 39774 +6
=======================================
+ Hits 38527 38533 +6
Misses 1241 1241
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Node.js Engineering Board
automation
moved this from Needs PR Review
to Done: Issues recently completed
Dec 4, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have cognitive complexity checks and they were disabled for openai instrumentation. This PR addresses that by hoisting functions into the root of file instead of within module.exports.