refactor: change dynamic import to work with bundlers

[atodd]

Moving the './' path to the require statement allows bundlers to find the api.js and stub_api.js files

Description

Move path for api dynamic import to require statement in initApi.

Related Issues

Closes #1904

[CLAassistant]

All committers have signed the CLA.

[jsumners-nr]

👋 thank you for the contribution. It looks like it should work correctly, but Node v18.19.0 has introduced an issue in our CI. I have a PR out to an upstream module solve that problem and we can hopefully get it dealt with soon.

[jsumners-nr]

The fix has been landed in our repo. @atodd can you rebase your branch please?

[bizob2828]

@atodd just for my own edification can you explain your fix? Your change just moves the ./ to be hardcoded in the require. Does your bundler configuration look for something ./${apiPath}? If so, why can't it just look for apiPath? Is it because it's too ambiguous?

[atodd]

@bizob2828 My understanding (at least for the bundlers I have used, mainly Vite and Webpack) is that require($apiPath) is too ambiguous because the bundlers can not determine the value of $apiPath. However, adding the ./ tells the bundler what directory a file will be dynamically imported from.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bf22ae5) 96.88% compared to head (cfdf2a5) 96.88%.
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1905   +/-   ##
=======================================
  Coverage   96.88%   96.88%           
=======================================
  Files         209      209           
  Lines       39872    39872           
=======================================
  Hits        38631    38631           
  Misses       1241     1241           

Flag	Coverage Δ
integration-tests-16.x	78.70% <100.00%> (-0.02%)	⬇️
integration-tests-18.x	78.96% <100.00%> (-0.02%)	⬇️
integration-tests-20.x	78.97% <100.00%> (-0.02%)	⬇️
unit-tests-16.x	90.88% <100.00%> (ø)
unit-tests-18.x	90.87% <100.00%> (ø)
unit-tests-20.x	90.87% <100.00%> (ø)
versioned-tests-16.x	73.79% <ø> (-0.03%)	⬇️
versioned-tests-18.x	73.79% <ø> (-0.03%)	⬇️
versioned-tests-20.x	73.80% <ø> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.