feat: removed api.setLlmMetadata as llm metadata will be assigned via api.addCustomAttribute with a prefix of llm.
#1918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… api.addCustomAttribute with a prefix of `llm.`
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1918 +/- ##
==========================================
- Coverage 96.98% 96.98% -0.01%
==========================================
Files 212 212
Lines 40060 40036 -24
==========================================
- Hits 38853 38829 -24
Misses 1207 1207
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Node.js Engineering Board
automation
moved this from Needs PR Review
to Done: Issues recently completed
Dec 18, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It was discusssed with AI team that
setLlmMetadatawas too rigid. They wanted a dynamic way to assign attributes. We already have that inapi.addCustomAttribute(s). The AI will associate llm metadata downstream if custom attributes on transaction matchllm.as the prefix to the attributes names. With that we're also changing conversation id to bellm.conversation_id.