test: Refactored tests that were still using the tap mocha shim + chai to now use tap. #1919
Conversation
bizob2828
force-pushed
the
remove-mocha
branch
from
0f912ce
to
8a50a6b
Compare
bizob2828
force-pushed
the
remove-mocha
branch
from
8a50a6b
to
da61b76
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1919 +/- ##
==========================================
- Coverage 96.98% 96.97% -0.01%
==========================================
Files 212 212
Lines 40060 40036 -24
==========================================
- Hits 38853 38826 -27
- Misses 1207 1210 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -71,639 +65,572 @@ function FakeSegment(transaction, duration, name = 'FakeSegment') { | |||
| } | |||
| } | |||
|
|
|||
| const helper = (module.exports = { | |||
There was a problem hiding this comment.
I really like that this sort of declaration has been removed. It's quite difficult to read and keep track of. I think the refactored declaration is also going to help quite a lot with jsdoc and ide integration. The only thing missing from the refactor is the removal of the singleton _agent.
There was a problem hiding this comment.
yea this was something I wasn't planning on doing but had to edit a few things here so broke this down. The agent singleton is going to be a heavier lift. I don't know the effects of this. I can log a story in our cleanup feature for this
| // Min port: 1024 (without root) | ||
| // Max port: 65535 | ||
| // Our range: 1024-65024 | ||
| const port = Math.ceil(Math.random() * 64000 + 1024) |
There was a problem hiding this comment.
For what it's worth, this could be:
| const port = Math.ceil(Math.random() * 64000 + 1024) | |
| const port = require('crypto').randomInt(1024, 65024) |
There was a problem hiding this comment.
I'd like to stick with this kind of refactor in a diff PR, I agree though. I'll queue that one up later
Description
This PR refactored the remaining tests that still relied on mocha + chai. I also consolidated some of the custom test assertions into
test/lib/custom-assertions.js. Lastly, I refactored the metrics helpers to not longer use assert and/or chai and use tap. With all of that I was able to remove chai from the devDependency list. This will also help developers triaging failulres in tests as they are now all tap assertions. When relying on mocha + chai it was very difficult at times, or even worse relying on the built in assert package.