Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: updated abort controller test expected error message based on undici version #1935

Merged
merged 1 commit into from Jan 8, 2024

Conversation

bizob2828
Copy link
Member

@bizob2828 bizob2828 commented Jan 8, 2024

Description

CI was failing after the 6.3.0 release of undici.

# Subtest: should add errors to transaction when external segment exists
        ok 1 - segment "ROOT" should have child "External/localhost:33941/delay/1000"
        ok 2 - should be equal
        not ok 3 - should be equal
          ---
          compare: ===
          at:
            line: 244
            column: 11
            file: requests.tap.js
          stack: |
            requests.tap.js:244:11
          source: |2
                    t.equal(tx.exceptions.length, 1)
                    t.equal(tx.exceptions[0].error.message, 'Request aborted')
            ----------^
                    tx.end()
                    t.end()
          diff: |
            --- expected
            +++ actual
            @@ -1,1 +1,1 @@
            -Request aborted
            +This operation was aborted
          ...
        
        1..3
        # failed 1 of 3 tests

Looks like generic error on aborted request changes. This PR updates that to handle it accordingly.

@bizob2828 bizob2828 added the dev:tests Indicates only changes to tests label Jan 8, 2024
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (10762a7) 97.02% compared to head (2075a9b) 97.02%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1935      +/-   ##
==========================================
- Coverage   97.02%   97.02%   -0.01%     
==========================================
  Files         215      215              
  Lines       40240    40239       -1     
==========================================
- Hits        39041    39040       -1     
  Misses       1199     1199              
Flag Coverage Δ
integration-tests-16.x 78.92% <ø> (+0.01%) ⬆️
integration-tests-18.x 79.17% <ø> (-0.02%) ⬇️
integration-tests-20.x 79.19% <ø> (ø)
unit-tests-16.x 91.10% <ø> (+<0.01%) ⬆️
unit-tests-18.x 91.08% <ø> (+<0.01%) ⬆️
unit-tests-20.x 91.08% <ø> (+<0.01%) ⬆️
versioned-tests-16.x 73.96% <ø> (-0.03%) ⬇️
versioned-tests-18.x 73.98% <ø> (-0.03%) ⬇️
versioned-tests-20.x 73.99% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bizob2828 bizob2828 merged commit 3e79cc7 into newrelic:main Jan 8, 2024
25 checks passed
Node.js Engineering Board automation moved this from Needs PR Review to Done: Issues recently completed Jan 8, 2024
@github-actions github-actions bot mentioned this pull request Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev:tests Indicates only changes to tests
Projects
Node.js Engineering Board
  
Done: Issues recently completed
Development

Successfully merging this pull request may close these issues.

None yet

2 participants