Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Updated lib/shim/shim.js to remove cognitive complexity violations #1950

Merged
merged 1 commit into from Jan 17, 2024

Conversation

bizob2828
Copy link
Member

Description

  • Fixed most jsdoc violations
  • Refactored shim but reducing cognitive complexity. This was done by removing nested functions

Related Issues

Closes NR-134577

lib/shim/shim.js Outdated Show resolved Hide resolved
@mrickard mrickard self-assigned this Jan 17, 2024
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (04fee88) 97.02% compared to head (c5bcaef) 97.03%.

Files Patch % Lines
lib/shim/shim.js 98.30% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #1950    +/-   ##
========================================
  Coverage   97.02%   97.03%            
========================================
  Files         215      215            
  Lines       40258    40372   +114     
========================================
+ Hits        39062    39176   +114     
  Misses       1196     1196            
Flag Coverage Δ
integration-tests-16.x 78.89% <64.97%> (+0.01%) ⬆️
integration-tests-18.x 79.15% <64.97%> (+0.02%) ⬆️
integration-tests-20.x 79.16% <64.97%> (+<0.01%) ⬆️
unit-tests-16.x 91.12% <97.74%> (+0.02%) ⬆️
unit-tests-18.x 91.11% <97.74%> (+0.02%) ⬆️
unit-tests-20.x 91.11% <97.74%> (+0.02%) ⬆️
versioned-tests-16.x 74.00% <91.80%> (+0.04%) ⬆️
versioned-tests-18.x 74.02% <91.80%> (+0.04%) ⬆️
versioned-tests-20.x 74.03% <91.80%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bizob2828 bizob2828 merged commit 60e57a1 into newrelic:main Jan 17, 2024
22 checks passed
Node.js Engineering Board automation moved this from Needs PR Review to Done: Issues recently completed Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Node.js Engineering Board
  
Done: Issues recently completed
Development

Successfully merging this pull request may close these issues.

None yet

3 participants