New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added transaction ID to ErrorTrace event #1954
feat: Added transaction ID to ErrorTrace event #1954
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1954 +/- ##
=======================================
Coverage 97.03% 97.03%
=======================================
Files 215 215
Lines 40372 40373 +1
=======================================
+ Hits 39176 39177 +1
Misses 1196 1196
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@bizob2828 I've fixed the tests checking the transaction id is present as you suggested since I have access to the transaction.id in the tests. |
Co-authored-by: James Sumners <jsumners@newrelic.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 🇮🇹
Description
We need to add the transaction id to ErrorTrace event to link Transactions to Traces.
Added transaction.id as the last field of the Error Trace JSON payload if the error occurs within a transaction.
Example error trace payload:
How to Test
Updated some unit tests. Added unit tests that confirm transaction id is added to error trace json when distributed tracking is both turned off and turned on.
Related Issues
Closes #1951