Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing concat-stream package #198

Closed
wants to merge 1 commit into from
Closed

Added missing concat-stream package #198

wants to merge 1 commit into from

Conversation

shadone
Copy link

@shadone shadone commented Jul 11, 2015

No description provided.

@shadone
Copy link
Author

shadone commented Jul 11, 2015

The latest released version of node-newrelic v1.21.0 introduced a bug that completely breaks new relic monitoring:

Here is what we see on startup:

New Relic for Node.js was unable to bootstrap itself due to an error:
Error: Cannot find module 'concat-stream'
    at Function.Module._resolveFilename (module.js:336:15)
    at Function.Module._load (module.js:278:25)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.<anonymous> (/var/app/current/node_modules/newrelic/lib/aws-info.js:6:14)
    at Module._compile (module.js:460:26)
    at Object.Module._extensions..js (module.js:478:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)

@shadone
Copy link
Author

shadone commented Jul 11, 2015

I've also created a support request #153194 regarding this issue.

@Awk34
Copy link

Awk34 commented Jul 12, 2015

that's a strange-looking commit

@shadone
Copy link
Author

shadone commented Jul 12, 2015

I've added the package with npm install --save concat-stream which reorders packages to be alphabetically sorted (which I believe is a standard introduced last(?) year in npm tool).

@Awk34
Copy link

Awk34 commented Jul 12, 2015

:P yeah I figured. GitHub interprets it strangely too, the first line change
On Jul 12, 2015 05:24, "Denis Dzyubenko" notifications@github.com wrote:

I've added the package with npm install --save concat-stream which
reorders packages to be alphabetically sorted (which I believe is a
standard introduced last(?) year in npm tool).


Reply to this email directly or view it on GitHub
#198 (comment)
.

@wraithan
Copy link
Contributor

We'll likely not use this PR as we'll need to add the license to specific files to make sure tests pass (We have tests to make sure our dependencies' license hasn't changed). We've unpublished the bad version and will be publishing a new one early next week with everything corrected.

The unpublish happened yesterday afternoon, shortly after this PR and after support contacted me.

@wraithan wraithan closed this Aug 18, 2015
bizob2828 added a commit to bizob2828/node-newrelic that referenced this pull request Apr 19, 2024
…/protobufjs-7.2.4

Bump protobufjs from 7.2.2 to 7.2.4
bizob2828 added a commit to bizob2828/node-newrelic that referenced this pull request Apr 23, 2024
…/protobufjs-7.2.4

Bump protobufjs from 7.2.2 to 7.2.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants