Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update eslint config #1980

Merged
merged 2 commits into from Jan 29, 2024
Merged

Conversation

jsumners-nr
Copy link
Contributor

This PR updates the eslint configuration to utilize our latest centralized configuration. This eliminates false errors on modern JavaScript syntax (e.g. class properties).

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f33c0cc) 97.04% compared to head (e408a82) 97.04%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1980   +/-   ##
=======================================
  Coverage   97.04%   97.04%           
=======================================
  Files         218      218           
  Lines       40493    40493           
=======================================
  Hits        39297    39297           
  Misses       1196     1196           
Flag Coverage Δ
integration-tests-16.x 78.93% <ø> (ø)
integration-tests-18.x 79.18% <ø> (-0.02%) ⬇️
integration-tests-20.x 79.20% <ø> (+<0.01%) ⬆️
unit-tests-16.x 91.15% <ø> (ø)
unit-tests-18.x 91.13% <ø> (ø)
unit-tests-20.x 91.13% <ø> (ø)
versioned-tests-16.x 74.09% <ø> (-0.03%) ⬇️
versioned-tests-18.x 74.12% <ø> (-0.03%) ⬇️
versioned-tests-20.x 74.12% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.eslintrc.js Outdated Show resolved Hide resolved
@jsumners-nr jsumners-nr merged commit 8991a15 into newrelic:main Jan 29, 2024
22 checks passed
Node.js Engineering Board automation moved this from Needs PR Review to Done: Issues recently completed Jan 29, 2024
@jsumners-nr jsumners-nr deleted the eslint-update branch January 29, 2024 19:56
svetlanabrennan pushed a commit to svetlanabrennan/node-newrelic that referenced this pull request Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Node.js Engineering Board
  
Done: Issues recently completed
Development

Successfully merging this pull request may close these issues.

None yet

2 participants