Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: updated prisma versioned test range to skip 5.9.0 as it was broken #1993

Merged
merged 1 commit into from Feb 1, 2024

Conversation

bizob2828
Copy link
Member

@bizob2828 bizob2828 commented Feb 1, 2024

Prisma fixed their exports issues in 5.9.1 this PR updates the versioned test range to skip 5.9.0 but continue testing on newer versions

Links

Closes #1984

@bizob2828 bizob2828 added the dev:tests Indicates only changes to tests label Feb 1, 2024
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5eae6ee) 97.04% compared to head (4f80297) 97.04%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1993   +/-   ##
=======================================
  Coverage   97.04%   97.04%           
=======================================
  Files         218      218           
  Lines       40493    40538   +45     
=======================================
+ Hits        39297    39342   +45     
  Misses       1196     1196           
Flag Coverage Δ
integration-tests-16.x 78.92% <ø> (-0.02%) ⬇️
integration-tests-18.x 79.18% <ø> (+<0.01%) ⬆️
integration-tests-20.x 79.20% <ø> (+<0.01%) ⬆️
unit-tests-16.x 91.15% <ø> (+<0.01%) ⬆️
unit-tests-18.x 91.13% <ø> (+<0.01%) ⬆️
unit-tests-20.x 91.13% <ø> (+<0.01%) ⬆️
versioned-tests-16.x 74.12% <ø> (+<0.01%) ⬆️
versioned-tests-18.x 74.15% <ø> (+<0.01%) ⬆️
versioned-tests-20.x 74.15% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -11,7 +11,7 @@
"node": ">=16"
},
"dependencies": {
"@prisma/client": ">=5.0.0 <5.9.0",
"@prisma/client": ">=5.0.0 <5.9.0 || >=5.9.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎊 Nice to see!

@bizob2828 bizob2828 merged commit d885286 into newrelic:main Feb 1, 2024
26 checks passed
Node.js Engineering Board automation moved this from Needs PR Review to Done: Issues recently completed Feb 1, 2024
@github-actions github-actions bot mentioned this pull request Feb 7, 2024
svetlanabrennan pushed a commit to svetlanabrennan/node-newrelic that referenced this pull request Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev:tests Indicates only changes to tests
Projects
Node.js Engineering Board
  
Done: Issues recently completed
Development

Successfully merging this pull request may close these issues.

Prisma instrumentation no longer works on >5.9.0
3 participants