feat: Added ai_monitoring.streaming.enabled. When set to false this will not instrument chat completion streams, thus it will not create relevant Llm events.
#2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will not instrument chat completion streams, thus it will not create relevant Llm events.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2021 +/- ##
=======================================
Coverage 97.10% 97.11%
=======================================
Files 239 239
Lines 41037 41066 +29
=======================================
+ Hits 39851 39880 +29
Misses 1186 1186
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bizob2828
commented
Feb 15, 2024
jsumners-nr
approved these changes
Feb 15, 2024
Node.js Engineering Board
automation
moved this from Needs PR Review
to Done: Issues recently completed
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The specification has been updated to have a new configuration
ai_monitoring.streaming.enabled. It will default to true. If customers are having issues with our stream instrumentation they can disable this option.It will not instrument stream and create the relevant Llm events. However it will still create the span,
Supportability/Nodejs/ML/<library>/<version>metric and addllm: trueto the transaction.Related Issues
Closes #2018