Add NEW_RELIC_LOG_ENABLED as a BOOLEAN_VARS
#203
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You could not disable logging via an environment var not set in code because it would not be converted to a boolean value properly. This allows it to be set properly from the environment because the `BOOLEAN_VARS` are converted to booleans.
|
@jakecraige wow, that's a pretty big whoops! Thanks for surfacing this. I'll chat with our team about getting this into the next release! |
|
Currently running this PR against many versions of node to verify nothing unexpected happens. |
|
@jakecraige this has been merge and released in v1.24.0 Thanks! |
bizob2828
added a commit
to bizob2828/node-newrelic
that referenced
this pull request
Apr 19, 2024
ci: skip version 3.377.0 of aws sdk packages as they are broken
bizob2828
added a commit
to bizob2828/node-newrelic
that referenced
this pull request
Apr 23, 2024
ci: skip version 3.377.0 of aws sdk packages as they are broken
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You could not disable logging via an environment var not set in code because it
would not be converted to a boolean value properly.
This allows it to be set properly from the environment because the
BOOLEAN_VARSare converted to booleans.