Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add note about using sudo for firewall script #2032

Merged
merged 1 commit into from Feb 20, 2024

Conversation

jsumners-nr
Copy link
Contributor

This PR updates the documentation around the macos-firewall.sh script to note that it should be run using elevated privileges.

@jsumners-nr jsumners-nr added the documentation Improvements or additions to documentation label Feb 20, 2024
@jsumners-nr jsumners-nr merged commit bf106d2 into newrelic:main Feb 20, 2024
22 checks passed
Node.js Engineering Board automation moved this from Needs PR Review to Done: Issues recently completed Feb 20, 2024
@jsumners-nr jsumners-nr deleted the doc-update branch February 20, 2024 16:45
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4378173) 97.11% compared to head (cfaa19e) 97.11%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2032   +/-   ##
=======================================
  Coverage   97.11%   97.11%           
=======================================
  Files         239      239           
  Lines       41108    41108           
=======================================
  Hits        39922    39922           
  Misses       1186     1186           
Flag Coverage Δ
integration-tests-16.x 78.72% <ø> (ø)
integration-tests-18.x 78.73% <ø> (-0.01%) ⬇️
integration-tests-20.x 78.73% <ø> (-0.02%) ⬇️
unit-tests-16.x 91.14% <ø> (ø)
unit-tests-18.x 91.05% <ø> (ø)
unit-tests-20.x 91.05% <ø> (ø)
versioned-tests-16.x 75.09% <ø> (-0.03%) ⬇️
versioned-tests-18.x 75.11% <ø> (-0.03%) ⬇️
versioned-tests-20.x 75.12% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Node.js Engineering Board
  
Done: Issues recently completed
Development

Successfully merging this pull request may close these issues.

None yet

2 participants