feat: Added ability to recordLlmFeedbackEvent by traceId #2043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2043 +/- ##
==========================================
- Coverage 97.15% 97.15% -0.01%
==========================================
Files 248 247 -1
Lines 41600 41560 -40
==========================================
- Hits 40418 40378 -40
Misses 1182 1182
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jsumners-nr
previously approved these changes
Feb 26, 2024
Yea I will queue those up. We cannot merge until the agent has been released. |
|
Ok this Pr will have a branched version of aws-sdk instrumentation. I cannot merge that until we release a new version of the agent |
bizob2828
force-pushed
the
update-llm-feedback
branch
from
30e6b8b
to
93d458f
Compare
jsumners-nr
approved these changes
Feb 26, 2024
Node.js Engineering Board
automation
moved this from Needs PR Review
to Done: Issues recently completed
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated
api.recordLlmFeedbackEventto require atraceIdobtained viaapi.getTraceMetadata. I also removedgetLlmMessageIdsapi as it no longer needed to get the relevant ids to post feedback. Lastly, we no longer need thetx.llm.responsesset to store these ids to be used ingetLlmMessageIds. This is technically a breaking change but since AIM is in limited preview we are no releasing as a semver major.Related Issues
Closes #2042