Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Added some delays to docs publishing #2062

Merged
merged 1 commit into from Mar 4, 2024

Conversation

jsumners-nr
Copy link
Contributor

After adding verbosity to docs gen (https://github.com/newrelic/node-newrelic/actions/runs/8145456792/job/22261755414) it looks like some operations are happening out-of-order (it could just be the way GitHub Actions records the logs, though). This PR adds some delays to try and solve that problem.

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.16%. Comparing base (fe0d41a) to head (74ed818).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2062   +/-   ##
=======================================
  Coverage   97.16%   97.16%           
=======================================
  Files         247      247           
  Lines       41755    41755           
=======================================
  Hits        40573    40573           
  Misses       1182     1182           
Flag Coverage Δ
integration-tests-16.x 78.39% <ø> (ø)
integration-tests-18.x 78.37% <ø> (ø)
integration-tests-20.x 78.37% <ø> (+<0.01%) ⬆️
unit-tests-16.x 90.62% <ø> (ø)
unit-tests-18.x 90.60% <ø> (ø)
unit-tests-20.x 90.60% <ø> (ø)
versioned-tests-16.x 74.58% <ø> (-0.03%) ⬇️
versioned-tests-18.x 75.44% <ø> (-0.03%) ⬇️
versioned-tests-20.x 75.45% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bizob2828 bizob2828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is necessary. I think it's just how GHA buffers and outputs stdout and stderr

@bizob2828 bizob2828 added the dev:automation Indicates CI automation label Mar 4, 2024
@bizob2828 bizob2828 merged commit a602fd4 into newrelic:main Mar 4, 2024
24 checks passed
Node.js Engineering Board automation moved this from Needs PR Review to Done: Issues recently completed Mar 4, 2024
@jsumners-nr jsumners-nr deleted the docs-slower branch March 4, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev:automation Indicates CI automation
Projects
Node.js Engineering Board
  
Done: Issues recently completed
Development

Successfully merging this pull request may close these issues.

None yet

2 participants