Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Changed casing of OpenAI in vendor property #2068

Merged
merged 1 commit into from Mar 7, 2024
Merged

chore: Changed casing of OpenAI in vendor property #2068

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/llm-events/openai/event.js
View file
Open in desktop
Expand Up @@ -19,7 +19,7 @@ module.exports = class LlmEvent extends BaseEvent {
this.span_id = segment?.id
this.transaction_id = segment?.transaction?.id
this['response.model'] = response.model
this.vendor = 'openAI'
this.vendor = 'openai'
this.ingest_source = 'Node'
this.metadata = agent

Expand Down
2 changes: 1 addition & 1 deletion test/unit/llm-events/openai/common.js
View file
Open in desktop
Expand Up @@ -53,7 +53,7 @@ function getExpectedResult(tx, event, type, completionId) {
'span_id': trace.children[0].id,
'transaction_id': tx.id,
'response.model': 'gpt-3.5-turbo-0613',
'vendor': 'openAI',
'vendor': 'openai',
'ingest_source': 'Node'
}
const resKeys = {
Expand Down
4 changes: 2 additions & 2 deletions test/versioned/openai/common.js
View file
Open in desktop
Expand Up @@ -55,7 +55,7 @@ function assertChatCompletionMessages({
'span_id': tx.trace.root.children[0].id,
'transaction_id': tx.id,
'response.model': model,
'vendor': 'openAI',
'vendor': 'openai',
'ingest_source': 'Node',
'role': 'user',
'is_response': false,
Expand Down Expand Up @@ -103,7 +103,7 @@ function assertChatCompletionSummary({ tx, model, chatSummary, tokenUsage, error
'span_id': tx.trace.root.children[0].id,
'transaction_id': tx.id,
'response.model': model,
'vendor': 'openAI',
'vendor': 'openai',
'ingest_source': 'Node',
'request.model': model,
'duration': tx.trace.root.children[0].getDurationInMillis(),
Expand Down
2 changes: 1 addition & 1 deletion test/versioned/openai/embeddings.tap.js
View file
Open in desktop
Expand Up @@ -93,7 +93,7 @@ tap.test('OpenAI instrumentation - embedding', (t) => {
'span_id': tx.trace.root.children[0].id,
'transaction_id': tx.id,
'response.model': 'text-embedding-ada-002-v2',
'vendor': 'openAI',
'vendor': 'openai',
'ingest_source': 'Node',
'request.model': 'text-embedding-ada-002',
'duration': tx.trace.root.children[0].getDurationInMillis(),
Expand Down