Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Removed langchain_instrumentation feature flag as the instrumentation is feature complete #2073

Merged
merged 1 commit into from Mar 12, 2024

Conversation

bizob2828
Copy link
Member

Description

langchain is feature complete. feature flag is no longer needed.

Related Issues

Closes #2072

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.18%. Comparing base (66f94b0) to head (eebad7f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2073      +/-   ##
==========================================
- Coverage   97.18%   97.18%   -0.01%     
==========================================
  Files         248      248              
  Lines       41938    41936       -2     
==========================================
- Hits        40756    40754       -2     
  Misses       1182     1182              
Flag Coverage Δ
integration-tests-16.x 78.23% <75.00%> (+<0.01%) ⬆️
integration-tests-18.x 78.22% <75.00%> (-0.01%) ⬇️
integration-tests-20.x 78.23% <75.00%> (+<0.01%) ⬆️
unit-tests-16.x 90.49% <100.00%> (-0.01%) ⬇️
unit-tests-18.x 90.47% <100.00%> (-0.01%) ⬇️
unit-tests-20.x 90.47% <100.00%> (-0.01%) ⬇️
versioned-tests-16.x 74.49% <75.00%> (-0.02%) ⬇️
versioned-tests-18.x 75.60% <100.00%> (-0.03%) ⬇️
versioned-tests-20.x 75.61% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bizob2828 bizob2828 merged commit 925a463 into newrelic:main Mar 12, 2024
24 checks passed
Node.js Engineering Board automation moved this from Needs PR Review to Done: Issues recently completed Mar 12, 2024
@bizob2828 bizob2828 deleted the langchain-ff-removal branch April 3, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Node.js Engineering Board
  
Done: Issues recently completed
Development

Successfully merging this pull request may close these issues.

Remove langchain feature flag.
2 participants