Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Removed transaction_id and legacy token count attributes from llm events for openai and langchain #2093

Merged
merged 1 commit into from Apr 1, 2024

Conversation

bizob2828
Copy link
Member

Description

The UI ticket will land today. I needed to do this to properly manually test the integration.

Related Issues

Closes #2057

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.21%. Comparing base (666ae6e) to head (aec607a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2093      +/-   ##
==========================================
- Coverage   97.21%   97.21%   -0.01%     
==========================================
  Files         251      251              
  Lines       42398    42392       -6     
==========================================
- Hits        41216    41210       -6     
  Misses       1182     1182              
Flag Coverage Δ
integration-tests-16.x 78.24% <ø> (-0.01%) ⬇️
integration-tests-18.x 78.22% <ø> (+<0.01%) ⬆️
integration-tests-20.x 78.23% <ø> (-0.01%) ⬇️
unit-tests-16.x 90.59% <ø> (-0.01%) ⬇️
unit-tests-18.x 90.57% <ø> (-0.01%) ⬇️
unit-tests-20.x 90.57% <ø> (-0.01%) ⬇️
versioned-tests-16.x 74.50% <ø> (-0.03%) ⬇️
versioned-tests-18.x 75.61% <ø> (-0.03%) ⬇️
versioned-tests-20.x 75.62% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrickard mrickard self-assigned this Mar 21, 2024
@bizob2828
Copy link
Member Author

The UI changes haven't been deployed to production as of 3/22/24. Please check next week with the linked jira before merging

@bizob2828 bizob2828 merged commit df2a0fd into newrelic:main Apr 1, 2024
24 checks passed
Node.js Engineering Board automation moved this from Needs PR Review to Done: Issues recently completed Apr 1, 2024
@bizob2828 bizob2828 deleted the aim-cleanup branch April 3, 2024 19:42
@github-actions github-actions bot mentioned this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Node.js Engineering Board
  
Done: Issues recently completed
2 participants