chore: Updated versioned security agent workflow #2100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node.js Engineering Board
automation
moved this from Needs PR Review
to Done: Issues recently completed
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #2088. It adds a new job to the
versioned-security-agentworkflow that detects if thepackage.jsonhas been updated, and if so, whether or not the@newrelic/security-agentversion number has been changed. The results of this job are utilized by the already existing job to determine if it should run. After this PR there are three cases where the versioned tests will run with the security agent enabled:@newrelic/security-agentdependency.Note: the CI run https://github.com/newrelic/node-newrelic/actions/runs/8455455203/job/23162959574?pr=2100 as a result of opening this PR shows that the security agent enabled tests do not run for every PR (this PR does not change the dependency version).